This repository has been archived by the owner on Dec 1, 2024. It is now read-only.
OSBuildEnvConfig: Implement conditions array #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CRD --- Add Conditions array to OSBuildEnvConfigStatus Controller ---------- Add owner watch to setup Jobs Initialize the conditions array Wait for the workers setup jobs to complete Update the conditions array Update UT Predicates ----------- Add a predicate waiting for a job to complete Add UT
bardielle
reviewed
Sep 8, 2022
| for i := range instance.Spec.Workers { | ||
| configured, err := r.ensureWorkerConfigured(ctx, reqLogger, instance, &instance.Spec.Workers[i]) | ||
| if err != nil { | ||
| return false, err |
There was a problem hiding this comment.
maybe you can use the condition message to update that not all the workers were configured properly.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CRD
Add Conditions array to OSBuildEnvConfigStatus
Controller
Add owner watch to setup Jobs
Initialize the conditions array
Wait for the workers setup jobs to complete
Update the conditions array
Update UT
Predicates
Add a predicate waiting for a job to complete
Add UT