return empty Customer object instead of None

project-koku · Jan 6, 2025 · 09aab51 · 09aab51
1 parent 0b23289
commit 09aab51
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/koku/koku/middleware.py b/koku/koku/middleware.py
@@ -251,7 +251,7 @@ def create_customer(account, org_id, request_method):
             org_id (str): The org_id identifier.
             request_method (str): The HTTP request method.
         Returns:
-            Customer | None: The created  or retrieved customer, or None if not found.
+            Customer : The created  or retrieved customer, or empty customer object if not found.
         """
         try:
             with transaction.atomic():
@@ -270,8 +270,8 @@ def create_customer(account, org_id, request_method):
             try:
                 customer = Customer.objects.filter(org_id=org_id).get()
             except Customer.DoesNotExist:
-                LOG.warning(f"Customer for org_id {org_id} does not exist. Returning None.")
-                return None
+                LOG.warning(f"Customer for org_id {org_id} does not exist. Returning empty object.")
+                customer = Customer(account_id="", org_id="", schema_name="")
 
         return customer
 

diff --git a/koku/koku/test_middleware.py b/koku/koku/test_middleware.py
@@ -521,7 +521,8 @@ def test_create_customer_integrity_error_customer_does_not_exist(self, mock_save
 
         customer = IdentityHeaderMiddleware.create_customer("test_account", "test_org", "POST")
 
-        self.assertIsNone(customer)
+        self.assertIsNotNone(customer)
+        self.assertEqual(customer.org_id, "")
         mock_save.assert_called_once()
         mock_filter.assert_called_once_with(org_id="test_org")
         mock_query_set.get.assert_called_once()