Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COST-4740] Migrations for OCP Cloud table network columns #5086

Merged
merged 5 commits into from
May 9, 2024

Conversation

cgoodfred
Copy link
Contributor

Jira Ticket

COST-4740

Description

This change will create the migration to add 3 new columns to the OCP on Cloud project daily summary tables. These columns will be used in the back populate SQL to identify and separate the inbound and outbound network rows into individual records. SQL reference: https://github.com/project-koku/koku/pull/5056/files#diff-ce52b5a5d2f1381263e888209eda7ab5277d7fc6a362551955113ae8861d21f3R67-R74

Testing

  1. Migration should run up and down successfully

Release Notes

  • proposed release note
* [COST-4740](https://issues.redhat.com/browse/COST-4740) Migration to add network columns to OCP on Cloud Project Daily Summary tables.

@cgoodfred cgoodfred added the smoke-tests pr_check will build the image and run minimal required smokes label May 4, 2024
@cgoodfred cgoodfred self-assigned this May 4, 2024
@cgoodfred cgoodfred added the skip-migration-check Skip migration test in CI. Useful for separating model changes from the migration. label May 4, 2024
Copy link

codecov bot commented May 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.1%. Comparing base (3b1c16a) to head (9f425d2).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #5086   +/-   ##
=====================================
  Coverage   94.1%   94.1%           
=====================================
  Files        377     377           
  Lines      31375   31375           
  Branches    3724    3724           
=====================================
  Hits       29531   29531           
  Misses      1173    1173           
  Partials     671     671           

@cgoodfred cgoodfred marked this pull request as ready for review May 4, 2024 11:49
@cgoodfred cgoodfred requested review from a team as code owners May 4, 2024 11:49
@samdoran samdoran added the django migration Change requires a Django database migration label May 8, 2024
@samdoran samdoran enabled auto-merge (squash) May 8, 2024 20:16
@samdoran samdoran merged commit ccbd7b6 into main May 9, 2024
11 checks passed
@samdoran samdoran deleted the COST-4740-OCP-cloud-columns branch May 9, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
django migration Change requires a Django database migration skip-migration-check Skip migration test in CI. Useful for separating model changes from the migration. smoke-tests pr_check will build the image and run minimal required smokes smokes-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants