-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[COST-5015] Retrieve azure disk capacities #5089
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5089 +/- ##
=====================================
Coverage 94.2% 94.2%
=====================================
Files 378 378
Lines 31583 31624 +41
Branches 3754 3756 +2
=====================================
+ Hits 29738 29778 +40
- Misses 1175 1177 +2
+ Partials 670 669 -1 |
/retest |
maskarb
previously approved these changes
May 16, 2024
cgoodfred
reviewed
May 16, 2024
cgoodfred
approved these changes
May 16, 2024
/retest |
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
hot-fix-smoke-tests
pr_check label to run minimal smoke tests for fast moving bug-fix
smokes-required
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
COST-5015
Description
This change will create a table to house a mapping of product substrings related to Azure managed disks and their capacities in GiBs.
Testing
Hit masu endpoint, and check table:
Release Notes