Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix log message #5422

Merged
merged 1 commit into from
Dec 9, 2024
Merged

fix log message #5422

merged 1 commit into from
Dec 9, 2024

Conversation

lcouzens
Copy link
Contributor

@lcouzens lcouzens commented Dec 9, 2024

Jira Ticket

Description

This change will prevent us always logging the warning.

Release Notes

  • proposed release note
* Prevent from always logging a warning.

@lcouzens lcouzens added the hot-fix-smoke-tests pr_check label to run minimal smoke tests for fast moving bug-fix label Dec 9, 2024
@lcouzens lcouzens marked this pull request as ready for review December 9, 2024 16:44
@lcouzens lcouzens requested review from a team as code owners December 9, 2024 16:44
Copy link
Contributor

@myersCody myersCody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📈

@lcouzens lcouzens enabled auto-merge (squash) December 9, 2024 16:47
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.1%. Comparing base (2862ffb) to head (56ea1d7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #5422   +/-   ##
=====================================
  Coverage   94.1%   94.1%           
=====================================
  Files        371     371           
  Lines      31534   31534           
  Branches    3377    3377           
=====================================
+ Hits       29686   29688    +2     
+ Misses      1201    1200    -1     
+ Partials     647     646    -1     

@lcouzens lcouzens merged commit c56449c into main Dec 9, 2024
14 checks passed
@lcouzens lcouzens deleted the fix-log branch December 9, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hot-fix-smoke-tests pr_check label to run minimal smoke tests for fast moving bug-fix smokes-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants