[COST-5565] - dont match on empty resource ids (OCP/AWS managed tables)

[lcouzens]

Jira Ticket

COST-5565

Description

This change will filter out OCP resources with an empty resource_id ''

Testing

1. Checkout Branch
2. Restart Koku
3. Hit endpoint or launch shell
   1. You should see ...
4. Do more things...

Release Notes

• proposed release note

* [COST-5565](https://issues.redhat.com/browse/COST-5565) Fix OCP/AWS managed table resource matching on `''`

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.1%. Comparing base (ed36ae7) to head (f6db644).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##            main   #5425     +/-   ##
=======================================
- Coverage   94.2%   94.1%   -0.0%     
=======================================
  Files        371     371             
  Lines      31542   31542             
  Branches    3378    3378             
=======================================
- Hits       29698   29696      -2     
- Misses      1198    1199      +1     
- Partials     646     647      +1     

[myersCody]

If customers have not updated their operator they will not have the csi_volume_handle. So, we need to account for the case where a persistentvolume has been populated, but the csi_volume_handle has not.

[lcouzens]

I wondered if that might be a case!! Thanks. I originally just had the check on persistentvolume but wasnt sure if that would be enough. Based on what your saying I think that would be the better approach here.

[myersCody]

We do still need to prevent an empty csi_volume handle string on the condition though or it will always return true. Give this a try, I have not ran it so it may need some tweaking:

OR (volumes.csi_volume_handle != '' AND substr(resource_names.lineitem_resourceid, -length(volumes.csi_volume_handle)) = volumes.csi_volume_handle)