Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unleash flag to skip trino tag matched get logic #5436

Merged
merged 5 commits into from
Jan 7, 2025

Conversation

lcouzens
Copy link
Contributor

@lcouzens lcouzens commented Jan 7, 2025

Jira Ticket

Description

This change will add an unleash flag to skip trino matched tag querying.

Testing

  1. Checkout Branch
  2. Restart Koku
  3. enable unleash flag to skip trino tag processing
  4. Ingest OCP on Cloud data with tag matching
  5. should see logs saying matched tag fetching was skipped

@lcouzens lcouzens added the smoke-tests pr_check will build the image and run minimal required smokes label Jan 7, 2025
@lcouzens lcouzens requested review from a team as code owners January 7, 2025 13:27
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.2%. Comparing base (0df02e7) to head (2796ce9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #5436     +/-   ##
=======================================
- Coverage   94.2%   94.2%   -0.0%     
=======================================
  Files        371     371             
  Lines      31542   31546      +4     
  Branches    3378    3379      +1     
=======================================
+ Hits       29701   29704      +3     
- Misses      1195    1196      +1     
  Partials     646     646             

maskarb
maskarb previously approved these changes Jan 7, 2025
@lcouzens lcouzens added hot-fix-smoke-tests pr_check label to run minimal smoke tests for fast moving bug-fix and removed smoke-tests pr_check will build the image and run minimal required smokes labels Jan 7, 2025
@lcouzens lcouzens enabled auto-merge (squash) January 7, 2025 15:17
@lcouzens lcouzens merged commit 78793e3 into main Jan 7, 2025
14 checks passed
@lcouzens lcouzens deleted the cost-unleash-flag-trino-tag-matching branch January 7, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hot-fix-smoke-tests pr_check label to run minimal smoke tests for fast moving bug-fix smokes-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants