Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix amortised cost calculations #5446

Merged
merged 9 commits into from
Jan 16, 2025

Conversation

lcouzens
Copy link
Contributor

@lcouzens lcouzens commented Jan 15, 2025

Jira Ticket

COST-####

Description

The only line items types that need to use savingsplan_savingsplaneffectivecost instead of unblended when calculating amortised_cost today are SavingsPlanCoveredUsage and SavingsPlanNegation

Instead of adding all variants of line item types it makes more sense to only consider these two line item types instead.

Testing

Tested this against internal data comparing directly with the bill

Happy to share this directly with people if your interested.

Release Notes

  • proposed release note
* [COST-####](https://issues.redhat.com/browse/COST-####) Fix some things

@lcouzens lcouzens requested review from a team as code owners January 15, 2025 13:16
@lcouzens lcouzens added the smoke-tests pr_check will build the image and run minimal required smokes label Jan 15, 2025
@lcouzens
Copy link
Contributor Author

/retest

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.2%. Comparing base (aabdbae) to head (4963922).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #5446   +/-   ##
=====================================
  Coverage   94.2%   94.2%           
=====================================
  Files        370     370           
  Lines      31539   31539           
  Branches    3378    3378           
=====================================
  Hits       29700   29700           
  Misses      1196    1196           
  Partials     643     643           

@lcouzens lcouzens changed the title handle EDP and Private rate discounts for amortised cost calculations Fix amortised cost calculations Jan 16, 2025
@lcouzens lcouzens merged commit 43f3859 into main Jan 16, 2025
14 checks passed
@lcouzens lcouzens deleted the handle-edp-private-rate-for-amortised-costs branch January 16, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
smoke-tests pr_check will build the image and run minimal required smokes smokes-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants