-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix amortised cost calculations #5446
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcouzens
added
the
smoke-tests
pr_check will build the image and run minimal required smokes
label
Jan 15, 2025
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5446 +/- ##
=====================================
Coverage 94.2% 94.2%
=====================================
Files 370 370
Lines 31539 31539
Branches 3378 3378
=====================================
Hits 29700 29700
Misses 1196 1196
Partials 643 643 |
lcouzens
changed the title
handle EDP and Private rate discounts for amortised cost calculations
Fix amortised cost calculations
Jan 16, 2025
maskarb
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
COST-####
Description
The only line items types that need to use
savingsplan_savingsplaneffectivecost
instead ofunblended
when calculatingamortised_cost
today areSavingsPlanCoveredUsage
andSavingsPlanNegation
Instead of adding all variants of line item types it makes more sense to only consider these two line item types instead.
Testing
Tested this against internal data comparing directly with the bill
Happy to share this directly with people if your interested.
Release Notes