Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COST-5796] correctly log exception outside log_json function #5448

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

djnakabaale
Copy link
Contributor

Jira Ticket

COST-5796

Description

This change is a followup on #5431, to correctly pass exception outside log_json function.

Testing

  1. Checkout Branch
  2. Restart Koku
  3. Run unit test and see log message
python3 koku/manage.py test koku.test_middleware.IdentityHeaderMiddlewareTest.test_create_customer_integrity_error_existing_customer

Release Notes

  • correctly log exception outside log_json function
* [COST-5796](https://issues.redhat.com/browse/COST-5796) correctly log exception outside log_json function

@djnakabaale djnakabaale requested review from a team as code owners January 15, 2025 15:44
@djnakabaale djnakabaale added the hot-fix-smoke-tests pr_check label to run minimal smoke tests for fast moving bug-fix label Jan 15, 2025
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.2%. Comparing base (aabdbae) to head (80e699d).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #5448   +/-   ##
=====================================
  Coverage   94.2%   94.2%           
=====================================
  Files        370     370           
  Lines      31539   31539           
  Branches    3378    3378           
=====================================
+ Hits       29700   29702    +2     
+ Misses      1196    1195    -1     
+ Partials     643     642    -1     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hot-fix-smoke-tests pr_check label to run minimal smoke tests for fast moving bug-fix smokes-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant