Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

undo POSTGRES_SQL_SERVICE_HOST/PORT in docker-compose #5462

Merged
merged 1 commit into from
Jan 22, 2025
Merged

undo POSTGRES_SQL_SERVICE_HOST/PORT in docker-compose #5462

merged 1 commit into from
Jan 22, 2025

Conversation

maskarb
Copy link
Member

@maskarb maskarb commented Jan 22, 2025

Description

This change will undo the POSTGRES_SQL_SERVICE_HOST and POSTGRES_SQL_SERVICE_PORT in the docker compose file. These need to be modified manually if wanting to connect to a db outside of docker.

Testing

  1. with koku running:
python koku/manage.py migrate_schemas

will succeed

@maskarb maskarb requested review from a team as code owners January 22, 2025 17:34
@maskarb maskarb merged commit ee89131 into main Jan 22, 2025
11 of 12 checks passed
@maskarb maskarb deleted the undo-variables branch January 22, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcouzens lcouzens lcouzens approved these changes

@myersCody myersCody myersCody approved these changes

Assignees
No one assigned
Labels
ok-to-skip-smokes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maskarb @myersCody @lcouzens