Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COST-5565] - Adding inserts for missed column entries #5464

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

lcouzens
Copy link
Contributor

@lcouzens lcouzens commented Jan 23, 2025

Jira Ticket

COST-5565

Description

This change will add the missing entries for lineitem_usagetype, lineitem_operation, product_vcpu and product_memory. These were created in the managed table but never inserted into.

Testing

  1. Checkout Branch
  2. Restart Koku
  3. Load OCP on AWS data
  4. Check managed table vs old

Example:
select distinct(lineitem_usagetype, lineitem_operation, product_vcpu, product_memory) from aws_openshift_daily;
AND
select distinct(lineitem_usagetype, lineitem_operation, product_vcpu, product_memory) from managed_aws_openshift_daily;

  1. You should see these columns populated in the new table

Release Notes

  • proposed release note
* [COST-5565](https://issues.redhat.com/browse/COST-5565) Fix missing column inserts (managed tables)

@lcouzens lcouzens added the smoke-tests pr_check will build the image and run minimal required smokes label Jan 23, 2025
@lcouzens lcouzens requested review from a team as code owners January 23, 2025 11:29
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.1%. Comparing base (708a7d4) to head (83ca781).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #5464     +/-   ##
=======================================
- Coverage   94.2%   94.1%   -0.0%     
=======================================
  Files        370     370             
  Lines      31551   31551             
  Branches    3381    3381             
=======================================
- Hits       29708   29705      -3     
- Misses      1196    1199      +3     
  Partials     647     647             

@lcouzens lcouzens merged commit d78ebdf into main Jan 23, 2025
14 checks passed
@lcouzens lcouzens deleted the add-missing-inserts-into-managed-columns branch January 23, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
smoke-tests pr_check will build the image and run minimal required smokes smokes-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants