fix(build): set correct codesigning target #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladfi1
force-pushed
the
build-mac-fix
branch
3 times, most recently
from
79664ca to
d3a5616
Compare
NikhilNarayana
requested changes
Jun 1, 2024
CMake doesn't seem to properly set the link libraries, not sure why.
NikhilNarayana
approved these changes
Jun 1, 2024
NikhilNarayana
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple changes needed to get the
build-mac.shscript working on my M1 machine.The xxhash thing is unsatisfying but oh well.