Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add linux #267

Closed
wants to merge 49 commits into from
Closed

Add linux #267

wants to merge 49 commits into from

Conversation

TaYaKi71751
Copy link
Contributor

@TaYaKi71751 TaYaKi71751 commented Dec 10, 2023 •
edited
Loading

@TaYaKi71751 TaYaKi71751 marked this pull request as draft December 10, 2023 19:05
@TaYaKi71751 TaYaKi71751 force-pushed the dev branch 16 times, most recently from cfe15c4 to c8beaca Compare December 10, 2023 23:00
@TaYaKi71751
Copy link
Contributor Author

TaYaKi71751 commented Dec 10, 2023 •
edited
Loading

Tested on AppImage
image
image

@TaYaKi71751 TaYaKi71751 marked this pull request as ready for review December 10, 2023 23:25
@TaYaKi71751 TaYaKi71751 marked this pull request as draft December 10, 2023 23:41
@TaYaKi71751 TaYaKi71751 force-pushed the dev branch 9 times, most recently from 53a4ecc to 087fc1c Compare December 11, 2023 07:49
@TaYaKi71751
Copy link
Contributor Author

https://github.com/TaYaKi71751/violet/releases/tag/latest-5eb68fa3348df9b14d7e944d66c4208a1205f220

@violet-dev
Copy link
Member

혹시 리뷰해도 되는 걸까요?

@TaYaKi71751
Copy link
Contributor Author

https://github.com/TaYaKi71751/violet/releases/tag/latest-ba260c11d489ee92306dc45bc46d5b30fd3f31a8

@TaYaKi71751
Copy link
Contributor Author

혹시 리뷰해도 되는 걸까요?

예

@violet-dev
Copy link
Member

변경 사항이 굉장히 많은데요, 이 pr은 그대로 놔둔 상태에서 본문의 내용대로 linux 지원과 독립된 issue는 cherry-pick해서 새로운 pr로 올려주시면 감사하겠습니다.
그대로 리뷰하기엔 양이 많아서 감당이 안될 것 같네요 😢

@TaYaKi71751
Copy link
Contributor Author

TaYaKi71751 commented Dec 23, 2023 •
edited
Loading

변경 사항이 굉장히 많은데요, 이 pr은 그대로 놔둔 상태에서 본문의 내용대로 linux 지원과 독립된 issue는 cherry-pick해서 새로운 pr로 올려주시면 감사하겠습니다. 그대로 리뷰하기엔 양이 많아서 감당이 안될 것 같네요 😢

@TaYaKi71751 TaYaKi71751 deleted the branch project-violet:dev December 24, 2023 04:54
@TaYaKi71751 TaYaKi71751 deleted the dev branch December 24, 2023 04:54
@TaYaKi71751
Copy link
Contributor Author

this branch was moved to dev-archive1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TaYaKi71751 @violet-dev