Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix forEach issue for eh-bookmark #280

Closed
wants to merge 79 commits into from

Conversation

@TaYaKi71751 TaYaKi71751 marked this pull request as draft December 24, 2023 07:50
@TaYaKi71751 TaYaKi71751 marked this pull request as ready for review December 24, 2023 07:57
@TaYaKi71751
Copy link
Contributor Author

I tested on Android

  • when use articleList.forEach((element) async {})
  • Bookmark wasn't loaded
  • when use await Future.forEach(articleList,(element) async {})
  • Bookmark was loaded

async hasIgneousCookie(), async hasSkCookie(), async refreshEhentaiCookie(), async refreshExhentaiCookie()
@TaYaKi71751 TaYaKi71751 force-pushed the fix-foreach-bug branch 2 times, most recently from 333a170 to a7cf16a Compare December 26, 2023 01:23
@TaYaKi71751 TaYaKi71751 marked this pull request as draft December 26, 2023 04:06
@TaYaKi71751
Copy link
Contributor Author

BUT

Use loading
was worked too

@TaYaKi71751 TaYaKi71751 marked this pull request as ready for review December 26, 2023 10:20
@TaYaKi71751
Copy link
Contributor Author

some gallery_token could not be search by ?next=${(id) + 1}
then just add use duckduckgo when could not be search by ?next=${(id) + 1}

@TaYaKi71751 TaYaKi71751 marked this pull request as draft December 27, 2023 02:29
@TaYaKi71751
Copy link
Contributor Author

I need to add proxied duckduckgo search

@TaYaKi71751 TaYaKi71751 marked this pull request as ready for review December 27, 2023 04:36
@TaYaKi71751
Copy link
Contributor Author

TaYaKi71751 commented Dec 27, 2023

Just can watch tags on bookmark page
(Tested on LM-G710N)
Screenshot_20231227-150437

@TaYaKi71751
Copy link
Contributor Author

moved to #292
with TaYaKi71751#8 (merge to upstream)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants