Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds install rules to gnu/linux targets #110

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

hamgravy
Copy link

No description provided.

@Phillip-Wang
Copy link
Contributor

Hi, these patches work fine. However, the style of your code is quite different from Ne10.
Would you mind updating it?

@jeras
Copy link

jeras commented Sep 15, 2016

I created a new pull request with whitespace cleanup and I tested the install procedure
#134

@joesavage
Copy link
Member

joesavage commented Oct 11, 2016

Besides the formatting issues (resolved by @jeras in #134), these changes generally look good to me, with the caveat that I think the code for the uninstall procedure should be more formally attributed to its source. Particularly, the source licenses its content under CC BY 2.5, which outlines that this part of the patch should "give appropriate credit, provide a link to the license, and indicate if changes were made".

@jeras
Copy link

jeras commented Nov 9, 2016

Hi Joe, it seems you were given access to this repo, great.
I do not have the time to work on Ne10 install right now, but I will test it probably in a month and report the status.
I asked a Debian developer to package this project and here are the results:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=837078
https://qa.debian.org/developer.php?login=wookey%40debian.org
https://ftp-master.debian.org/new/ne10_1.2.1-3.html
You might be able to pisk something usefull from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants