CCP Red Dragon - SSU Fixes + Tests + Smart Gate #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
CCP-Red-Dragon
commented
Nov 22, 2024
•
CCP-Red-Dragon
commented
- Fixes for the SSU example and clearer logs for the execute script.
- Changing line endings for Windows users
- Update all readme's
- Added base tests for the smart turret + gate
- Added tests for the SSU example
- Added a basic smart gate example
- Altered the mprocs to allow for easier testing / development
|
Thanks @CCP-Red-Dragon for the fixes! I was close to reporting another issue with the examples as in the current example, you could make the ratio some maximum number of uint256 (which gives a |
Smart Storage Unit Example Fix Execute script simplifications Final SSU Changes Ratio quick change Line endings windows fix Hopefully fixing a line endings issue with Windows to Linux.
CCP-Red-Dragon
force-pushed
the
ccp-red-dragon/simplification
branch
from
9686564 to
bcfc386
Compare
CCP-Red-Dragon
changed the title
0xxlegolas
reviewed
Nov 28, 2024
0xxlegolas
reviewed
Nov 29, 2024
0xxlegolas
reviewed
Nov 29, 2024
0xxlegolas
reviewed
Nov 29, 2024
0xxlegolas
reviewed
Nov 29, 2024
0xxlegolas
reviewed
Nov 29, 2024
smart-storage-unit/packages/contracts/src/systems/SmartStorageUnitSystem.sol
Show resolved
Hide resolved
CCP-Red-Dragon
changed the title
0xxlegolas
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.