feat(ember): add work item list #174
Conversation
Yelinz
force-pushed
the
work-items
branch
2 times, most recently
from
6623a1a to
7696fc6
Compare
Yelinz
force-pushed
the
work-items
branch
2 times, most recently
from
f7fe4a5 to
06fe10d
Compare
|
update and improvement of the work item list, removed unnecessary parts relies on #210 |
Yelinz
requested review from
velrest and
derrabauke
and removed request for
czosel
Yelinz
force-pushed
the
work-items
branch
2 times, most recently
from
510e2b8 to
88a37a5
Compare
|
Refactored to ember-resources and added basic acceptance tests. |
| } | ||
|
|
||
| get case() { | ||
| return this.raw.case.parentWorkItem?.case || this.raw.case; |
There was a problem hiding this comment.
I don't see where we're fetching the parentWorkItem
ember/.eslintignore
Outdated
| # mirage | ||
| /mirage/mirage |
There was a problem hiding this comment.
Note for Prettier users
pin eslint-plugin-prettier to 2.6.0, or
add the following to .eslintignore: /mirage/mirage
There was a problem hiding this comment.
Have you tried it without this? ember-caluma doesn't have this..
ember/app/cases/detail/route.js
Outdated
| const caseQuery = useCalumaQuery(this, allCases, () => ({ | ||
| options: { pageSize: 1 }, | ||
| filter: [{ id: case_id }], | ||
| })); |
There was a problem hiding this comment.
This is not how useCalumaQuery works. This needs to be a property on the controller.. Please check out the documentation in ember-caluma
There was a problem hiding this comment.
Instead of fetching the same case/work item (duplicating this code snippet) in the child controllers, i opted to fetch them in the parent route model. What would be the best alternative to useCalumaQuery, just using apollo?
There was a problem hiding this comment.
Changed to apollo queries in controllers for both cases
| @dropTask() | ||
| *completeWorkItem() { | ||
| yield this.apollo.mutate({ | ||
| mutation: completeWorkItem, | ||
| variables: { id: this.workItem.id }, | ||
| }); | ||
|
|
||
| this.actionButtonOnSuccess(); | ||
| } |
There was a problem hiding this comment.
Use the built-in <WorkItemButton /> or the action button question type
| const workItemsQuery = useCalumaQuery(this, allWorkItems, () => ({ | ||
| options: { pageSize: 1 }, | ||
| filter: [{ id: work_item_id }], | ||
| })); |
| <div uk-drop> | ||
| <div class="uk-card uk-card-body uk-card-small uk-card-default"> |
There was a problem hiding this comment.
I think you want to use the uk-dropdown here - not a card in a drop
| @@ -8,7 +8,8 @@ | |||
| </LinkTo> | |||
|
|
|||
| <UkTab as |tab|> | |||
| <tab.item @href="/">{{t "nav.documents"}}</tab.item> | |||
| <tab.item @href="/form-builder">{{t "nav.form-builder"}}</tab.item> | |||
| <tab.item @href="/">{{t "nav.cases"}}</tab.item> | |||
There was a problem hiding this comment.
| <tab.item @href="/">{{t "nav.cases"}}</tab.item> | |
| <tab.item @href="/" @linkToIndex={{true}}>{{t "nav.cases"}}</tab.item> |
| /> | ||
|
|
||
| <div class="uk-width-expand uk-flex uk-flex-middle uk-text-meta uk-margin"> | ||
| <span> |
ember/app/work-items/controller.js
Outdated
| export default class WorkItemsController extends Controller { | ||
| queryParams = ["order", "status"]; | ||
|
|
||
| // Filters |
There was a problem hiding this comment.
I don't think that comment is very helpful, let's remove it
ember/app/work-items/controller.js
Outdated
|
|
||
| @action | ||
| updateFilter(type, value) { | ||
| set(this, type, value); |
There was a problem hiding this comment.
| set(this, type, value); | |
| this[type] = value; |
Yelinz
force-pushed
the
work-items
branch
2 times, most recently
from
8fd0dce to
3f5f6a9
Compare
Yelinz
requested review from
anehx
and removed request for
luytena and
StephanH90
adds a new view to display the work items to the user