New changes #1045
Open
New changes #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czosel
reviewed
Dec 17, 2024
| // if the user cancel title editing, | ||
| // return edit title input value to be the orginal title | ||
| this.title = this.args.document.title; | ||
| } |
There was a problem hiding this comment.
Let's fix it for the description as well, that way you might be able to use [name] generically
czosel
reviewed
Dec 17, 2024
| @@ -88,9 +88,6 @@ module("Acceptance | documents", function (hooks) { | |||
| assert | |||
| .dom("[data-test-single-doc-details] [data-test-title]") | |||
| .hasText(document.title); | |||
|
|
|||
| await click("[data-test-close]"); | |||
| assert.dom("[data-test-document-side-panel]").hasClass("closed"); | |||
There was a problem hiding this comment.
maybe you could click data-test-toggle-side-panel instead?
czosel
reviewed
Dec 17, 2024
| file.createdAt | ||
| month="2-digit" | ||
| day="2-digit" | ||
| year="numeric" |
There was a problem hiding this comment.
Let's try the two-row style instead, which should also work well on smaller screens
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is removing the "close" button inside the document side bar, because it is somewhat redundant (there is another button that does the same thing outside of the sidebar) and it causes a layout issue when editing the document title.
Before:
After:
