This repository has been archived by the owner on Feb 27, 2019. It is now read-only.
Add checkbox field type #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anehx
force-pushed
the
checkbox-field-type
branch
from
b6eae2d to
a5e11db
Compare
anehx
force-pushed
the
checkbox-field-type
branch
from
a5e11db to
b80bd48
Compare
czosel
reviewed
Oct 30, 2018
| listValue=(array "option-1") | ||
| ) | ||
| ) | ||
| }} |
There was a problem hiding this comment.
Wouldn't it be more readable to specify those nested objects in JS and pass them in as
field=field?
There was a problem hiding this comment.
That's a matter of taste I think. In this case it would maybe make sense, but I'd prefer to do it everywhere or nowhere in those tests. I think the best way would be to do it everywhere but in a seperate PR. Agree?
There was a problem hiding this comment.
I created an issue: #38
czosel
approved these changes
Oct 31, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #17