chore: udpate to ember 4.12 and make embroider optimized

BREAKING CHANGE:
- Ember.js v3.28 or above
- Ember CLI v3.28 or above
- Node.js v14 or above

.github/workflows/test.yml

@@ -61,9 +61,12 @@ jobs:
     strategy:
       matrix:
         scenario:
-          - ember-lts-3.28
-          - ember-release
-
+          - ember-lts-4.8
+          - ember-lts-4.12
+          # Disable for now since ember-data@4 causes an embroider build error. See https://github.com/projectcaluma/ember-emeis/pull/625#issuecomment-1614488464
+          # - ember-release
+          - embroider-safe
+          - embroider-optimized
     steps:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3

addon/components/relationship-select.hbs

@@ -4,27 +4,22 @@
   ...attributes
   {{did-insert (perform this.fetchModels)}}
 />
-{{#let
-  (component (if @multiple "power-select-multiple" "power-select"))
-  as |RelationPowerSelect|
-}}
-  <RelationPowerSelect
-    @searchEnabled={{this.searchEnabled}}
-    @search={{perform this.fetchModels}}
-    @options={{this.models}}
-    @selected={{@selected}}
-    @placeholder={{if
-      this.fetchModels.isRunning
-      (t "emeis.loading")
-      @placeholder
-    }}
-    @noMatchesMessage={{t "emeis.empty"}}
-    @renderInPlace={{true}}
-    @allowClear={{true}}
-    @onChange={{@onChange}}
-    {{did-update (perform this.fetchModels) @model}}
-    as |model|
-  >
-    {{yield model}}
-  </RelationPowerSelect>
-{{/let}}
+<this.selectComponent
+  @searchEnabled={{this.searchEnabled}}
+  @search={{perform this.fetchModels}}
+  @options={{this.models}}
+  @selected={{@selected}}
+  @placeholder={{if
+    this.fetchModels.isRunning
+    (t "emeis.loading")
+    @placeholder
+  }}
+  @noMatchesMessage={{t "emeis.empty"}}
+  @renderInPlace={{true}}
+  @allowClear={{true}}
+  @onChange={{@onChange}}
+  {{did-update (perform this.fetchModels) @model}}
+  as |model|
+>
+  {{yield model}}
+</this.selectComponent>

addon/components/relationship-select.js

@@ -1,6 +1,9 @@
 import { inject as service } from "@ember/service";
+import { isTesting, macroCondition } from "@embroider/macros";
 import Component from "@glimmer/component";
 import { restartableTask, lastValue, timeout } from "ember-concurrency";
+import PowerSelect from "ember-power-select/components/power-select";
+import PowerSelectMultiple from "ember-power-select/components/power-select-multiple";
 
 import { handleTaskErrors } from "ember-emeis/-private/decorators";
 
@@ -15,14 +18,20 @@ export default class RelationshipSelectComponent extends Component {
     return this.models && this.args.modelName && this.models.length > 5;
   }
 
+  get selectComponent() {
+    return this.args.multiple ? PowerSelectMultiple : PowerSelect;
+  }
+
   @restartableTask
   @handleTaskErrors
   *fetchModels(search) {
     if (this.args.model) {
       return this.args.model;
     }
     if (typeof search === "string") {
-      yield timeout(500);
+      if (macroCondition(!isTesting())) {
+        yield timeout(500);
+      }
       return yield this.store.query(this.args.modelName, {
         filter: { search },
       });

addon/components/tree.js

@@ -1,6 +1,7 @@
 import { isArray } from "@ember/array";
 import { action } from "@ember/object";
 import { inject as service } from "@ember/service";
+import { isTesting, macroCondition } from "@embroider/macros";
 import Component from "@glimmer/component";
 import { tracked } from "@glimmer/tracking";
 import { timeout, restartableTask } from "ember-concurrency";
@@ -43,7 +44,9 @@ export default class TreeComponent extends Component {
 
   @restartableTask
   *filter(event) {
-    yield timeout(100);
+    if (macroCondition(!isTesting())) {
+      yield timeout(100);
+    }
 
     const filterItems = (
       items,

addon/controllers/permissions/edit.js

@@ -17,4 +17,8 @@ export default class PermissionsEditController extends Controller {
 
     return model;
   }
+
+  @action setRoles(roles) {
+    this.model.roles = roles;
+  }
 }

addon/routes/index.js

@@ -1,7 +1,10 @@
 import Route from "@ember/routing/route";
+import { service } from "@ember/service";
 
 export default class IndexRoute extends Route {
+  @service hostRouter;
+
   beforeModel() {
-    this.transitionTo("users");
+    this.hostRouter.transitionTo("ember-emeis.users");
   }
 }

addon/routes/permissions/edit.js

@@ -6,6 +6,7 @@ import { handleModelErrors } from "ember-emeis/-private/decorators";
 export default class PermissionsEditRoute extends Route {
   @service notification;
   @service intl;
+  @service store;
 
   @handleModelErrors({ routeFor404: "permissions.index" })
   model({ permission_id: id }) {

addon/routes/permissions/new.js

@@ -1,8 +1,12 @@
+import { inject as service } from "@ember/service";
+
 import CreateRoute from "ember-emeis/-private/routes/create";
 
 export default class PermissionsNewRoute extends CreateRoute {
   detailView = "permissions.edit";
 
+  @service store;
+
   model() {
     return this.store.createRecord("permission");
   }

addon/routes/roles/edit.js

@@ -1,11 +1,12 @@
 import Route from "@ember/routing/route";
-import { inject as service } from "@ember/service";
+import { service } from "@ember/service";
 
 import { handleModelErrors } from "ember-emeis/-private/decorators";
 
 export default class RolesEditRoute extends Route {
   @service notification;
   @service intl;
+  @service store;
 
   @handleModelErrors({ routeFor404: "roles.index" })
   model({ role_id: id }) {

addon/routes/roles/new.js

@@ -1,6 +1,10 @@
+import { service } from "@ember/service";
+
 import CreateRoute from "ember-emeis/-private/routes/create";
 
 export default class RolesNewRoute extends CreateRoute {
+  @service store;
+
   detailView = "roles.edit";
 
   model() {

addon/routes/scopes.js

@@ -1,5 +1,5 @@
 import Route from "@ember/routing/route";
-import { inject as service } from "@ember/service";
+import { service } from "@ember/service";
 
 export default class ScopesRoute extends Route {
   @service store;

addon/routes/scopes/edit.js

@@ -1,5 +1,5 @@
 import Route from "@ember/routing/route";
-import { inject as service } from "@ember/service";
+import { service } from "@ember/service";
 
 import { handleModelErrors } from "ember-emeis/-private/decorators";
 

addon/routes/scopes/new.js

@@ -1,6 +1,10 @@
+import { service } from "@ember/service";
+
 import CreateRoute from "ember-emeis/-private/routes/create";
 
 export default class ScopesNewRoute extends CreateRoute {
+  @service store;
+
   detailView = "scopes.edit";
 
   model() {

addon/routes/users/edit.js

@@ -1,11 +1,12 @@
 import Route from "@ember/routing/route";
-import { inject as service } from "@ember/service";
+import { service } from "@ember/service";
 
 import { handleModelErrors } from "ember-emeis/-private/decorators";
 
 export default class UsersEditRoute extends Route {
   @service notification;
   @service intl;
+  @service store;
 
   @handleModelErrors({ routeFor404: "users.index" })
   async model({ user_id: id }) {

addon/routes/users/new.js

@@ -1,6 +1,10 @@
+import { service } from "@ember/service";
+
 import CreateRoute from "ember-emeis/-private/routes/create";
 
 export default class UsersNewRoute extends CreateRoute {
+  @service store;
+
   detailView = "users.edit";
 
   model() {

addon/templates/permissions/edit.hbs

@@ -49,7 +49,7 @@
       @modelName="role"
       @selected={{@model.roles}}
       @placeholder="{{t 'emeis.permissions.headings.roles'}}..."
-      @onChange={{set @model "roles"}}
+      @onChange={{this.setRoles}}
       @multiple="true"
       required
       as |role|

app/decorators/localized-attr.js

@@ -1 +1 @@
-export { default } from "ember-emeis/decorators/localized-attrs";
+export { default } from "ember-emeis/decorators/localized-attr";

ember-cli-build.js

@@ -13,9 +13,13 @@ module.exports = function (defaults) {
     This build file does *not* influence how the addon or the app using it
     behave. You most likely want to be modifying `./index.js` or app's build file
   */
-
-  const { maybeEmbroider } = require("@embroider/test-setup");
-  return maybeEmbroider(app, {
+  const { Webpack } = require("@embroider/webpack");
+  return require("@embroider/compat").compatBuild(app, Webpack, {
+    staticAddonTestSupportTrees: true,
+    staticAddonTrees: true,
+    staticHelpers: true,
+    staticModifiers: true,
+    staticComponents: true,
     skipBabel: [
       {
         package: "qunit",