Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cros_gralloc include directory #103

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JeevakaPrabu
Copy link
Collaborator

Removing hardcoded cros_gralloc include directory as it is already added in mfx_c2_defs.mk

Tracked-On: OAM-110710

Tracked-On: OAM-110710
Signed-off-by: Jeevaka Prabu Badrappan <[email protected]>
@@ -33,7 +33,7 @@ mfx_cc_defaults {
export_include_dirs: ["include"],

include_dirs: [
"hardware/intel/external/minigbm-intel/cros_gralloc", // remove then minigbm gets Android.bp
"hardware/intel/external/minigbm/cros_gralloc", // remove then minigbm gets Android.bp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks we don't have this folder hardware/intel/external/minigbm/cros_gralloc in celadon. What we have is hardware/intel/external/minigbm-intel.

@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci sysopenci requested review from dyang23 and TianmiChen June 14, 2023 05:53
@sysopenci sysopenci requested review from YuanjunHuang and yyao3 June 14, 2023 05:53
@sysopenci
Copy link

Android CI has completed Engineering Build for this issue, build is FAILURE. Please check the linked Tracked-On issue/Android CI Web for more details

@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci
Copy link

Android CI has completed Engineering Build for this issue, build is FAILURE. Please check the linked Tracked-On issue/Android CI Web for more details

@sysopenci sysopenci added the Stale Stale label for inactive open prs label Sep 6, 2024
@sysopenci
Copy link

one of the dependent pr's program name is not compatable with other dependent prs, for more details please check tracked_on

1 similar comment
@sysopenci
Copy link

one of the dependent pr's program name is not compatable with other dependent prs, for more details please check tracked_on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale Stale label for inactive open prs Valid commit message
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants