WA for TOUTIAO APP #118
Open
WA for TOUTIAO APP #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shao-Feng
force-pushed
the
toutiao_wa_commit
branch
from
fd4a934 to
114bfdc
Compare
zhangyichix
approved these changes
Oct 13, 2023
TianmiChen
reviewed
Oct 13, 2023
Shao-Feng
force-pushed
the
toutiao_wa_commit
branch
from
114bfdc to
cc2d2d0
Compare
TianmiChen
reviewed
Oct 17, 2023
| @@ -222,6 +221,13 @@ MfxC2DecoderComponent::MfxC2DecoderComponent(const C2String name, const CreateCo | |||
| .withConstValue(AllocSharedString<C2PortMediaTypeSetting::output>("video/raw")) | |||
| .build()); | |||
|
|
|||
| addParameter( | |||
| DefineParam(m_outputUsage, C2_PARAMKEY_OUTPUT_STREAM_USAGE) | |||
| .withDefault(new C2StreamUsageTuning::output(0u, C2AndroidMemoryUsage::HW_CODEC_WRITE)) | |||
There was a problem hiding this comment.
This is defined for consumer usage. Could you please use HW_TEXTURE_READ and HW_COMPOSER_READ for the default usage here?
enum consumer_t : uint64_t {
RENDERSCRIPT_READ = GRALLOC_USAGE_RENDERSCRIPT,
HW_TEXTURE_READ = GRALLOC_USAGE_HW_TEXTURE,
HW_COMPOSER_READ = GRALLOC_USAGE_HW_COMPOSER,
// gralloc does not define a video decoder read usage flag, so use encoder for
// now
HW_CODEC_READ = GRALLOC_USAGE_HW_VIDEO_ENCODER,
READ_PROTECTED = GRALLOC_USAGE_PROTECTED,
};
Shao-Feng
force-pushed
the
toutiao_wa_commit
branch
from
cc2d2d0 to
976080a
Compare
TianmiChen
approved these changes
Oct 17, 2023
Shao-Feng
force-pushed
the
toutiao_wa_commit
branch
from
976080a to
18a9f1a
Compare
|
Improper Commit Message |
Add a parameter to AOSP for setting the buffer useage of output memory Once it is set as CPU_READ, force to use system memory, instead of video memory. Remove the valiable m_consumerUsage which is only set as default. Tracked-On: OAM-111768 Signed-off-by: Shaofeng Tang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check /proc/PID/cmdline to see if the application is TouTiao. If yes, only use system memory to workaround the incorrect Bufferqueue.
Once APP fix Bufferqueue issue, please remove me.
Tracked-On: OAM-111768