Support dump input frames for encoder #186
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Improper Commit Message |
sysopenci
added
Pending Developer Approval
Tracked-On: OAM-124732 Signed-off-by: Lina Sun <[email protected]>
lsun30
force-pushed
the
encoder_dump
branch
from
be87236 to
7236faa
Compare
sysopenci
requested review from
dyang23,
feijiang1,
gkdeepa,
TianmiChen,
YuanjunHuang and
yyao3
feijiang1
reviewed
Sep 14, 2024
| if (m_count) { | ||
| const uint8_t* srcY = c_graph_view->data()[C2PlanarLayout::PLANE_Y]; | ||
| const uint8_t* srcU = c_graph_view->data()[C2PlanarLayout::PLANE_U]; | ||
| const uint8_t* srcV = c_graph_view->data()[C2PlanarLayout::PLANE_V]; |
There was a problem hiding this comment.
srcV seems useless. Due to NV12 format only has two planes, the srcU can be changed to srcUV.
feijiang1
reviewed
Sep 14, 2024
| @@ -1363,6 +1400,46 @@ void MfxC2EncoderComponent::DoWork(std::unique_ptr<C2Work>&& work) | |||
| } | |||
| } | |||
|
|
|||
| #if MFX_DEBUG_DUMP_FRAME_ENC == MFX_DEBUG_YES | |||
There was a problem hiding this comment.
it is better implemented as separate function
feijiang1
reviewed
Sep 14, 2024
| std::mutex m_count_lock; | ||
| FILE* m_file = 0; | ||
| bool NeedDumpBuffer(); | ||
| #endif |
There was a problem hiding this comment.
they are only used for dump function, then it is not needed placed under class MfxC2EncoderComponent, we can keep member of class minimal
feijiang1
reviewed
Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[c2][encoder] Support dump input frames for encoder
Tracked-On: OAM-124731
Signed-off-by: Lina Sun [email protected]