Gralloc4 support #25
Open
Gralloc4 support #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeevakaPrabu
force-pushed
the
gralloc4_support
branch
2 times, most recently
from
f5bf0ab to
98d9cf6
Compare
As per Gralloc 4.0 mapper, buffer has to be imported before its usage and released after its usage. Changes include: - Add importBuffer and release functions to Gralloc1 - Import the buffer before its usage. - Release the buffer after its usage. Tracked-On: OAM-105783 Co-authored-by: Jeevaka Prabu Badrappan <[email protected]> Signed-off-by: Deepa K G <[email protected]> Signed-off-by: Jeevaka Prabu Badrappan <[email protected]>
JeevakaPrabu
force-pushed
the
gralloc4_support
branch
from
98d9cf6 to
4d238e0
Compare
xmao4-intel
approved these changes
May 5, 2023
renchenglei
reviewed
May 6, 2023
| @@ -1079,35 +1080,49 @@ status_t VirtualFakeCamera3::processCaptureRequest(camera3_capture_request *requ | |||
| ALOGE("%s: Request %d: Buffer %zu: Fence timed out after %d ms", __FUNCTION__, | |||
| frameNumber, i, kFenceTimeoutMs); | |||
| } | |||
| destBuf.rawHandle = native_handle_clone(*(destBuf.buffer)); | |||
There was a problem hiding this comment.
Here we call native_handle_clone, but we didn't release the handle, will there be memory leak?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.