Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static Analysis Fix for Camera Vhal #42

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Static Analysis Fix for Camera Vhal #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/VirtualFakeCamera3.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3048,8 +3048,10 @@ bool VirtualFakeCamera3::ReadoutThread::threadLoop() {
result.partial_result = 1;
/*Coverity Fix: If the current camera device is not a logical multi-camera, or the
corresponding capture_request doesn't request on any physical camera,
this field must be 0*/
this field must be 0. Since we don't have any Physical Camera, the array of Strings containing Physical
camera Id is NULL*/
result.num_physcam_metadata=0;
result.physcam_ids = NULL;

// Go idle if queue is empty, before sending result
bool signalIdle = false;
Expand Down Expand Up @@ -3104,8 +3106,10 @@ void VirtualFakeCamera3::ReadoutThread::onJpegDone(const StreamBuffer &jpegBuffe

/*Coverity Fix: If the current camera device is not a logical multi-camera, or the
corresponding capture_request doesn't request on any physical camera,
this field must be 0*/
this field must be 0. Since we don't have any Physical Camera, the array of Strings containing Physical
camera Id is NULL*/
result.num_physcam_metadata=0;
result.physcam_ids = NULL;

if (!success) {
ALOGE(
Expand Down
Loading