Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable stagefright and recorder for debug #1961

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Enable stagefright and recorder for debug #1961

merged 1 commit into from
Jul 11, 2023

Conversation

haochuan1982
Copy link
Contributor

@haochuan1982 haochuan1982 commented Jul 4, 2023 •
edited
Loading

Enable stagefright and recorder for debug

Tracked-On: OAM-111132

@sysopenci
Copy link

Improper Commit Message
Jira issue not in ['bug','improvement'],
make sure jira issue is of type bug or improvement.

@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

@haochuan1982
Copy link
Contributor Author

@balajim001 @gkdeepa @padmashree9110 @dyang23 @xinxin-wan @libinyang

@xinxin-wan
Copy link

LGTM

gkdeepa
gkdeepa approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@gkdeepa gkdeepa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JeevakaPrabu
JeevakaPrabu suggested changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@JeevakaPrabu JeevakaPrabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also add detailed commit message on the changes done in stagefright

...adon_ivi/frameworks/av/cmds/stagefright/0002-Enable-stagefright-and-recorder-for-debug.patch Outdated Show resolved Hide resolved
...adon_ivi/frameworks/av/cmds/stagefright/0002-Enable-stagefright-and-recorder-for-debug.patch Outdated Show resolved Hide resolved
@sysopenci
Copy link

Improper Commit Message
Jira issue not in ['bug','improvement'],
make sure jira issue is of type bug or improvement.

@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci
Copy link

Android CI has completed Engineering Build for this issue, build is SUCCESS.To merge the changes please click on APPROVE FOR MERGE button in Android CI WEB

sysopenci
sysopenci reviewed Jul 10, 2023
View reviewed changes
Copy link

@sysopenci sysopenci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure when executing preintegration builder

FAILURE:CheckApprovals Some checks are failed. See the step results.html

More details, logs, and binaries: /absp/builders/celadon_smr0_master-preintegration/builds/277

@sysopenci
Copy link

Improper Commit Message
Jira issue not in ['bug','improvement'],
make sure jira issue is of type bug or improvement.

@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

gkdeepa
gkdeepa approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@gkdeepa gkdeepa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sysopenci
sysopenci reviewed Jul 11, 2023
View reviewed changes
Copy link

@sysopenci sysopenci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure when executing preintegration builder

FAILURE:CheckBug Bad comments/Bugs

More details, logs, and binaries: /absp/builders/celadon_smr0_master-preintegration/builds/294

sysopenci
sysopenci reviewed Jul 11, 2023
View reviewed changes
Copy link

@sysopenci sysopenci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure when executing preintegration builder

FAILURE:CheckBug Bad comments/Bugs

More details, logs, and binaries: /absp/builders/celadon_smr0_master-preintegration/builds/295

sysopenci
sysopenci reviewed Jul 11, 2023
View reviewed changes
Copy link

@sysopenci sysopenci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure when executing preintegration builder

FAILURE:CheckBug Bad comments/Bugs

More details, logs, and binaries: /absp/builders/celadon_smr0_master-preintegration/builds/296

@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

2 similar comments
@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci sysopenci requested a review from balajim001 July 11, 2023 08:29
@sysopenci
Copy link

Android CI has completed Engineering Build for this issue, build is FAILURE. Please check the linked Tracked-On issue/Android CI Web for more details

@sysopenci
Copy link

Android CI has completed Engineering Build for this issue, build is SUCCESS.To merge the changes please click on APPROVE FOR MERGE button in Android CI WEB

sysopenci
sysopenci reviewed Jul 11, 2023
View reviewed changes
Copy link

@sysopenci sysopenci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR integrated into 'preintegration' builder

More details, logs, and binaries: /absp/builders/celadon_smr0_master-preintegration/builds/297

Done by "Chen, Haochuan Z" [email protected]

sysopenci
sysopenci reviewed Jul 11, 2023
View reviewed changes
Copy link

@sysopenci sysopenci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR integrated into 'premerge' builder

More details, logs, and binaries: /absp/builders/celadon_smr0_master-premerge/builds/186

Done by "Chen, Haochuan Z" [email protected]

@sysopenci
Copy link

Android CI has completed Engineering Build for this issue, build is SUCCESS.To merge the changes please click on APPROVE FOR MERGE button in Android CI WEB

@haochuan1982
Enable stagefright with more configurable item for debug
e8cecb9 
More customized command option for stagefright

Add command option for format 24bit, 24bit packed,
32bit, with channel 1ch,5.1ch,7.1ch,7.1.4ch

Tracked-On: OAM-111132
Signed-off-by: Martin, Chen <[email protected]>
@sysopenci
Copy link

Android CI has completed Engineering Build for this issue, build is FAILURE. Please check the linked Tracked-On issue/Android CI Web for more details

1 similar comment
@sysopenci
Copy link

Android CI has completed Engineering Build for this issue, build is FAILURE. Please check the linked Tracked-On issue/Android CI Web for more details

@sysopenci sysopenci merged commit e82e455 into projectceladon:celadon/s/mr0/master Jul 11, 2023
sysopenci
sysopenci reviewed Jul 11, 2023
View reviewed changes
Copy link

@sysopenci sysopenci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cactus finished building and testing your changes

It was requested for merge by [email protected]

so we merge it. Thanks for your contribution.

more details, logs, and binaries: /absp/builders/celadon_smr0_master-mergerequest/builds/170

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sysopenci sysopenci sysopenci left review comments

@gkdeepa gkdeepa gkdeepa approved these changes

@balajim001 balajim001 Awaiting requested review from balajim001

@JeevakaPrabu JeevakaPrabu Awaiting requested review from JeevakaPrabu

@kaushlen kaushlen Awaiting requested review from kaushlen

@lchen43 lchen43 Awaiting requested review from lchen43

@rajucm2007 rajucm2007 Awaiting requested review from rajucm2007

@sgnanase sgnanase Awaiting requested review from sgnanase

@shyjumon-n shyjumon-n Awaiting requested review from shyjumon-n

@swaroopbalan swaroopbalan Awaiting requested review from swaroopbalan

@yyao3 yyao3 Awaiting requested review from yyao3

Assignees
No one assigned
Labels
PR approved Valid commit message
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@haochuan1982 @sysopenci @xinxin-wan @JeevakaPrabu @gkdeepa