Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable VP9 HDR support by default #2568

Merged
merged 1 commit into from
Aug 20, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
From 695fa89a4552a52498e92151440848aa4a968eed Mon Sep 17 00:00:00 2001
From: Lina Sun <[email protected]>
Date: Mon, 29 Jul 2024 08:06:16 +0000
Subject: [PATCH] By default disable HDR support for VP9 codec

The change is because current mediasdk_c2 doesn't support HDR for
VP9 codec, but in framework VP9 HDR is supported by default.

Will need to remove this patch when VP9 is supported in
mediasdk_c2.
---
media/codec2/sfplugin/Codec2InfoBuilder.cpp | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/media/codec2/sfplugin/Codec2InfoBuilder.cpp b/media/codec2/sfplugin/Codec2InfoBuilder.cpp
index 453a0d2f59..3e00dc5ee5 100644
--- a/media/codec2/sfplugin/Codec2InfoBuilder.cpp
+++ b/media/codec2/sfplugin/Codec2InfoBuilder.cpp
@@ -154,7 +154,9 @@ bool addSupportedProfileLevels(
// VP9 does not support HDR metadata in the bitstream and static metadata
// can always be carried by the framework. (The framework does not propagate
// dynamic metadata as that needs to be frame accurate.)
- supportsHdr |= (mediaType == MIMETYPE_VIDEO_VP9);
+ // TODO: comment out this line for now as VP9 HDR is not supported in SDK yet
+ // will need uncomment it when adding VP9 HDR support in SDK.
+ //supportsHdr |= (mediaType == MIMETYPE_VIDEO_VP9);

// HDR support implies 10-bit support. AV1 codecs are also required to
// support 10-bit per CDD.
--
2.34.1