Enable GeoGebra plugin to work totally offline

[martignoni]

• We add a new setting for the codebase of GeoGebra.
• This is useful eg. on a MoodleBox. See this discussion: https://discuss.moodlebox.net/d/361-offline-geogebra

Related to PR #70, but in the Moodle way :-)

[toniginard]

  Hi @martignoni,

About this line:

$codebase = !empty($geogebra->codebase) ? $geogebra->codebase : get_config('geogebra', 'codebase');

In the pull request is not included the code to add the codebase at activity-level. So, if the intention is to allow this, the field in the database and in the form is missing. But if the intention is just to load the string from the general settings, there is no need to check $geogebra->codebase. What is your idea?

Best wishes,

Toni Ginard

[toniginard]

Hi @martignoni,

I have modified your commit to make the codebase an optional setting for the module. I also set the default value to empty because the default value set, in my tests, caused a javascript error (in an activity, I lost the javascript keyboard). This way, that setting would transparent to the users that are not interested in it.

I have pushed that change to master branch.

Best wishes,

[martignoni]

Thanks, much appreciated. Closing.