[#244] Bring test suite up to date #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This dealt addresses messages like this: ``` DeprecationWarning: <class 'tests.backends.sqlalchemy.factories.AlchemyFactFactory.Meta'>.force_flush has been deprecat ed as of 2.8.0 and will be removed in 3.0.0. Please set ``<class 'tests.backends.sqlalchemy.factories.AlchemyFactFactory.Meta'>.sqlalchemy_session_persistence = 'flush'`` instead. ``` Ref.: #244
Ref.: #244
Due to recent work on legacy hamster, the old referenes (on master) do not work anymore. As they were just optional references anyway, they got removed. Ref.: #244
Codecov Report
@@ Coverage Diff @@
## develop #247 +/- ##
===========================================
- Coverage 96.06% 94.76% -1.31%
===========================================
Files 9 7 -2
Lines 941 993 +52
Branches 141 128 -13
===========================================
+ Hits 904 941 +37
- Misses 14 34 +20
+ Partials 23 18 -5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After returning to the codebase, the testsuite showed multiple issues.
This PR deal with them by:
xfail(Failed test after coming back #245 ), which needs to be dealt with seperately.legacy-hamster'smasterbranch.Outstanding issue: #245
We still get a warning about some fuckup with regards to scoped alchemy sessions. This will most likely take more time and should be addressed in a separate issue.
Closes: