-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency on gconf #443
Conversation
- save/load configuration in ~/.config/hamster-time-tracker/hamster.json - for now the file is accessed on every conf.set() and conf.get() call - completely removed gconf dependency (also in waf scripts)
Sorry, as i said, this will have to wait after v3.0. |
Okay, I guess it's ready when you are. |
OK, it was not clear that it was work in progress, But really I feel that handling configuration (with eg. file monitoring), is no small feat. What I would recommend is not implementing fancy file monitoring, |
My proposition is to move to very simple config file to handle our handful of configuration values. The file is re-read or re-written for every single access to any setting (i.e. conf.get('setting_name') or conf.set('setting_name, value), so no other file monitoring is needed. Not pretty or efficient or robust, but this little application doesn't need anything more complicated or robust, just like it doesn't need a more robust DB than sqlite3 for the real data storage. I have tested this, including external editing of settings, which are picked up immediately (well, the next time hamster needs to use the modified parameter). |
Even more interesting, but still need to think, later. |
I'll admit, I'm not sure I see the rationale for this direction. It seems like the course of least resistance here would be to simply move to GSettings. Adapting the schema should be trivial and the GSettings interface is reasonably similar to GConf. As has been pointed out, configuration management is not trivial and the ad hoc solution proposed here almost certainly won't be as robust as using a library. Let's avoid reinventing the wheel if possible. |
Okay, forget it. Release a new version of a Gnome software in 2019 still depending on gconf when Gnome itself abandoned gconf in 2011. Looking forward to someone else's better solution. |
Dear @GeraldJansen
Looks like a direct criticism to me. Maybe it should be added that I did look into this configuration stuff maybe a year ago, Your proposition is interesting too, On the contrary, I would really encourage you to merge master into this PR often, There might be a source of misunderstanding: Hoping you understand and we can continue united; |
Thanks @GeraldJansen! Quite alright, I think we've all been there :) |
@GeraldJansen It's OK, because your impetus usually helps this project, Now I would not like this project to lose two motivated contributors, |
Related to #64. Perhaps a complex migration is not necessary.