Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Rich Asset Add into Main #7

Open
wants to merge 31 commits into
base: master
Choose a base branch
from

Conversation

XieonCrypto
Copy link

Series of commits that add several assets for the new pokemon for the gen 9 part 2 DLC in sprite and normal variety forms

XieonCrypto and others added 30 commits November 3, 2023 13:55
Added a balls folder format tupe_ball
Changed folder structure
fixed lureball file name to be ball_lure.png
Updating the readme with relevant information since the repo this was forked from has not been updated sincee zerora
Added Lapras.png, Rhyhorn.png, Aron.png and Serverdex.txt which is a fully list of all current pokemon claimed from the serverdex
Organization updates, lining up remote and master, updated with some of the eevee event weekend assets
add assets sprites for eeveelution raids rest of
Updated with new sylveon asset
Umbreon asset update
Organization of files, moved all thumbnails into one folder to code easier.
Added charjabug to assets - 737
added 424, 609 608 0062 708 and 709 to the serverdex for tumbnails
This is for public repo - not using github token for sysbot right now - need to redo
Unique pixel style sprites for Terapagos, Archaludon, Raging Bolt and Iron Crown
@evandixon
Copy link
Member

I apologize for taking so long to getting around to reviewing this PR. I procrastinated towards the start, then it just got easier and easier to keep procrastinating the longer it's been.

This repository was the original source for this part of Project Pokemon: https://projectpokemon.org/home/gallery/category/2-image-dex/. I have a publisher program somewhere (maybe in a private repo, it's been a while) that can take the directory structure in the Pokedex folder and publish it to the albums on the site. Your branch, however, uses a fundamentally different directory structure, meaning the publisher cannot import everything in the same style.

There could be some value in adding these to the Unfiled directory in case someone in the future wanted to try to put things in the correct directory style, but there's some other issues such as

  • The readme in the PR being specific to your branch
  • The directory name being specific to your branch/use-case/brand

I applaud your effort in collecting images for the newer Pokemon, but in its current state, I don't think this repo is a good fit for your collection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants