Fix label selectors for ArgoCD servicemonitors #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We renamed the ServiceMonitors in #129 without verifying that the renamed service monitors still discover any endpoints. We need to split the ServiceMonitor name from the name used for the label selector to ensure that we can use an object name which doesn't collide with the operator-managed name, while still picking up the endpoints.
haasad
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We renamed the ServiceMonitors in #129 without verifying that the renamed service monitors still discover any endpoints.
We need to split the ServiceMonitor name from the name used for the label selector to ensure that we can use an object name which doesn't collide with the operator-managed name, while still picking up the endpoints.
Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.