Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hook=PostSync annotation from hook RBAC #168

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Conversation

simu
Copy link
Member

@simu simu commented Jun 26, 2024

This should fix the intermittent KubeJobFailed alerts for the post-sync hook job, since the job sometimes fails because the ServiceAccount and RBAC rules are missing.

Checklist

  • The PR has a meaningful title. It will be used to auto-generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • Categorize the PR by adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.

This should fix the intermittent KubeJobFailed alerts for the post-sync
hook job, since the job sometimes fails because the ServiceAccount and
RBAC rules are missing.
@simu simu added the bug Something isn't working label Jun 26, 2024
@simu simu requested a review from a team June 26, 2024 08:45
@simu simu merged commit 1b120ec into master Jun 27, 2024
13 checks passed
@simu simu deleted the fix/postsync-hook-rbac branch June 27, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants