Fix node discovery when compose-node-name is disabled #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simu
force-pushed
the
fix/nested-nodes-no-compose
branch
from
556a9b6 to
d064e20
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
bastjan
approved these changes
Jan 15, 2025
This comment was marked as outdated.
This comment was marked as outdated.
simu
force-pushed
the
fix/nested-nodes-no-compose
branch
from
a098c76 to
22ae757
Compare
This comment was marked as outdated.
This comment was marked as outdated.
simu
force-pushed
the
fix/nested-nodes-no-compose
branch
from
4c66715 to
89a582a
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
simu
force-pushed
the
fix/nested-nodes-no-compose
branch
from
a9f87e1 to
a804388
Compare
This comment was marked as outdated.
This comment was marked as outdated.
simu
force-pushed
the
fix/nested-nodes-no-compose
branch
from
a804388 to
1c5efb6
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Python reclass will still discover nested nodes if compose-node-name is disabled, but will strip the prefix path from the resulting node names (and the `parts` metadata). This commit adjusts reclass-rs to behave identically to Python reclass for inventories which contain nodes in subfolders of `inventory/nodes` when compose-node-name isn't enabled. Fixes #148
simu
force-pushed
the
fix/nested-nodes-no-compose
branch
from
1c5efb6 to
4e7ccc8
Compare
Benchmark for 3bffcf3Click to view benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python reclass will still discover nested nodes if compose-node-name is disabled, but will strip the prefix path from the resulting node names (and the
partsmetadata).This commit adjusts reclass-rs to behave identically to Python reclass for inventories which contain nodes in subfolders of
inventory/nodeswhen compose-node-name isn't enabled.Fixes #148
Checklist
bug,enhancement,documentation,change,breaking,dependency,internalas they show up in the changelog