Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated loadBundles script for connectathon and add QICore ModelInfo #112

Merged
merged 4 commits into from
Oct 4, 2024

Conversation

hossenlopp
Copy link
Contributor

Summary

Latest connectathon ecqm-content-qicore-2024 bundles still have some issues with references. This adds the loadBundles script from the previous connectathon and make it fix the current issues with the bundles references, specifically with the library relatedArtifact references.

Also adds QICore ModelInfo library that is now referenced by measures.

New behavior

npm run loadBundles in service project loads bundles in the ecqm-content-qicore-2024 repo into a running measure repository.

npm run db:setup now inserts the QICore ModelInfo library when setting up the database.

Code changes

New script script/loadBundles.

Testing guidance

  • npm run db:reset
  • Start up MRS and front end. Ensure FHIR ModelInfo and QICore ModelInfo exist in the library list
  • Have the latest ecqm-content-qicore-2024 repo checked out adjacent to this repository.
  • npm run loadBundles
  • This script will output a lot of info about what it does. Duplicate shared libraries will report uploading with 400 errors.
  • Ensure that measures appear in repository and can have $data-requirements executed on them in the UI and are able to show dependencies.

@hossenlopp hossenlopp requested a review from lmd59 September 23, 2024 20:31
@p9g
Copy link

p9g commented Sep 25, 2024

Previously reported by Elsa at cqframework/ecqm-content-qicore-2024#47

@elsaperelli elsaperelli self-requested a review September 25, 2024 13:19
@elsaperelli elsaperelli self-assigned this Sep 25, 2024
@elsaperelli
Copy link
Contributor

elsaperelli commented Sep 27, 2024

Refactored the code a bit so that we didn't have multiple script files with redundant code. Simply moved functions in loadBundles.ts to dbSetup.ts. The script can now be run with command npm run db:loadEcqmContent in the service directory. The user can provide an optional server URL input, but if none is provided then the default is http://localhost:3000/4_0_1. Thanks Hoss for adding this!!!

Copy link
Contributor Author

@hossenlopp hossenlopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unable to Request Changes since I created this PR. Theres / that got dropped in moving this to the dbSetup file that makes the corrected references not work.

service/scripts/dbSetup.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@elsaperelli elsaperelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@elsaperelli elsaperelli merged commit eb19b42 into main Oct 4, 2024
2 checks passed
@elsaperelli elsaperelli deleted the cthon-sept-2024 branch October 4, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants