knn: adding additional test case

projuce · Jul 11, 2016 · f339111 · f339111
1 parent 7041fc3
commit f339111
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/knn/knn_test.go b/knn/knn_test.go
@@ -66,7 +66,7 @@ func TestKnnClassifierWithOptimisations(t *testing.T) {
 	})
 }
 
-func TestKnnClassifierWithOptimisationsPartiallyComplete(t *testing.T) {
+func TestKnnClassifierWithTemplatedInstances1(t *testing.T) {
 	Convey("Given two basically identical files...", t, func() {
 		trainingData, err := base.ParseCSVToInstances("knn_train_2.csv", true)
 		So(err, ShouldBeNil)
@@ -79,3 +79,17 @@ func TestKnnClassifierWithOptimisationsPartiallyComplete(t *testing.T) {
 		So(predictions, ShouldNotBeNil)
 	})
 }
+
+func TestKnnClassifierWithTemplatedInstances1Subset(t *testing.T) {
+	Convey("Given two basically identical files...", t, func() {
+		trainingData, err := base.ParseCSVToInstances("knn_train_2.csv", true)
+		So(err, ShouldBeNil)
+		testingData, err := base.ParseCSVToTemplatedInstances("knn_test_2_subset.csv", true, trainingData)
+		So(err, ShouldBeNil)
+
+		cls := NewKnnClassifier("euclidean", 2)
+		cls.Fit(trainingData)
+		predictions := cls.Predict(testingData)
+		So(predictions, ShouldNotBeNil)
+	})
+}
diff --git a/knn/knn_test_2_subset.csv b/knn/knn_test_2_subset.csv
@@ -0,0 +1,2 @@
+weather,hours_of_daylight,number_of_customers
+cloudy,10.1,0
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		weather,hours_of_daylight,number_of_customers
		cloudy,10.1,0