Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed remote write regression #88

Merged
merged 2 commits into from
Sep 26, 2024
Merged

fixed remote write regression #88

merged 2 commits into from
Sep 26, 2024

Conversation

bwplotka
Copy link
Member

@bwplotka bwplotka commented Sep 26, 2024

We forgot to add it to the run group.

Fixes #86

Chained on top of #87

@bwplotka bwplotka changed the title fixed remote write regresion. fixed remote write regression Sep 26, 2024
cmd/avalanche.go Outdated Show resolved Hide resolved
Copy link

@MichaHoffmann MichaHoffmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Base automatically changed from remove-old-series to main September 26, 2024 10:39
Fixes #86

Signed-off-by: bwplotka <[email protected]>
@bwplotka bwplotka merged commit 5b08980 into main Sep 26, 2024
7 checks passed
@bwplotka bwplotka deleted the rwfix branch September 26, 2024 13:52
prateeknayak pushed a commit to prateeknayak/avalanche that referenced this pull request Jan 2, 2025
* fixed regressions around series leak due to races; refactor for clarity


* fixed remote write regresion.

Fixes prometheus-community#86


---------
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest main is not sending metrics compared to v0.5
2 participants