feat: Add option to run indefinitely; fix races #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Juraj Michalek <[email protected]>
Co-authored-by: Bartlomiej Plotka <[email protected]> Signed-off-by: Juraj Michálek <[email protected]>
Signed-off-by: Juraj Michalek <[email protected]>
Signed-off-by: Juraj Michalek <[email protected]>
…ability. Signed-off-by: bwplotka <[email protected]>
jmichalek132
approved these changes
Sep 27, 2024
|
LGTM. |
prateeknayak
pushed a commit
to prateeknayak/avalanche
that referenced
this pull request
Jan 2, 2025
) * feat add option to run indefinitely * Update metrics/write.go Co-authored-by: Bartlomiej Plotka <[email protected]> * ran go fmt * fix rename the variable everywhere * fix: Fixed race during update, improved infinite run logging and readability. --------- Co-authored-by: Juraj Michalek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @jmichalek132
This is on top of your #89 as mentioned offline
Tested manually:
go run cmd/avalanche.go --remote-url=http://remote.com --remote-tenant=redacted --remote-requests-count=-1 --remote-tenant-header=redacted --gauge-metric-count=200go run cmd/avalanche.go --remote-url=http://remote.com --remote-tenant=redacted --remote-requests-count=20 --remote-tenant-header=redacted --gauge-metric-count=200