Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheus-adapter] Add Support for sidecar containers #3739

Closed
rpriyanshu9 opened this issue Aug 30, 2023 · 1 comment · Fixed by #3737
Closed

[prometheus-adapter] Add Support for sidecar containers #3739

rpriyanshu9 opened this issue Aug 30, 2023 · 1 comment · Fixed by #3737
Labels
enhancement New feature or request

Comments

@rpriyanshu9
Copy link
Contributor

Is your feature request related to a problem ?

Currently there is no support for having sidecar containers in the helm chart. If a service like AWS Managed Prometheus (AMP) is being used then the adapter needs support for authentication with AWS using sigv4. Creating this issue because #1568 is closed because of being stale.

Describe the solution you'd like.

It would be good if there was an option of defining sidecar containers within the helm chart. Something like a variable inside the values file, which can be referenced in the deployment template.

Describe alternatives you've considered.

To get past this issue right now, I've forked the helm chart and added the required changes in the fork.

Additional context.

No response

@rpriyanshu9
Copy link
Contributor Author

Raised a PR for the same - #3737

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant