[prometheus-adapter] Add sidecar container support #3737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpriyanshu9
requested review from
hectorj2f,
MattiasGees and
steven-sheehy
as code owners
Signed-off-by: Priyanshu Raj <[email protected]>
rpriyanshu9
force-pushed
the
add-sidecar
branch
from
df913d6 to
5693975
Compare
Signed-off-by: Priyanshu Raj <[email protected]>
steven-sheehy
requested changes
Sep 12, 2023
Signed-off-by: Priyanshu Raj <[email protected]>
rpriyanshu9
force-pushed
the
add-sidecar
branch
from
e8ad0ed to
f07c1a8
Compare
Signed-off-by: Priyanshu Raj <[email protected]>
rpriyanshu9
force-pushed
the
add-sidecar
branch
from
f07c1a8 to
1343ca8
Compare
|
@steven-sheehy I've implemented the requested changes. Could you please take a look? |
steven-sheehy
approved these changes
Sep 29, 2023
Matiasmct
pushed a commit
to giffgaff/prometheus-charts-backup
that referenced
this pull request
Mar 20, 2024
…ity#3737) Signed-off-by: Priyanshu Raj <[email protected]> Signed-off-by: Priyanshu Raj <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This PR makes it possible to add sidecar containers to a prometheus-adapter deployment. This lets you put e.g. a sigv4 proxy sidecar (https://github.com/awslabs/aws-sigv4-proxy) alongside the main container, which we need in order to connect to Amazon Managed Service for Prometheus’s query endpoint.
Which issue this PR fixes
Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])