Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheus] Add "externalTrafficPolicy" to server's service #5261

Conversation

v0ctor
Copy link
Contributor

@v0ctor v0ctor commented Jan 31, 2025

What this PR does / why we need it

This PR adds support to the Prometheus chart to set "externalTrafficPolicy" option to server's service.

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

@v0ctor v0ctor force-pushed the feature/prometheus-external-traffic-policy branch from 41a0eb1 to 9b0295f Compare January 31, 2025 13:56
Copy link
Contributor

@zeritti zeritti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @v0ctor, for your PR. Please, see my comments below.

charts/prometheus/templates/service.yaml Outdated Show resolved Hide resolved
charts/prometheus/values.yaml Show resolved Hide resolved
@v0ctor
Copy link
Contributor Author

v0ctor commented Feb 3, 2025

Thank you very much, @zeritti. Changes applied!

Copy link
Contributor

@zeritti zeritti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @v0ctor, LGTM.

@zeritti zeritti merged commit 2760512 into prometheus-community:main Feb 3, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants