Cachevault support for storcli.py collector #120
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Franciszek Klajn <[email protected]> Signed-off-by: Morten Johansen <[email protected]>
Signed-off-by: prombot <[email protected]> Signed-off-by: Morten Johansen <[email protected]>
The `line == ''` check doesn't work in Python 3, which uses bytestrings. Replace it with `not line`. Signed-off-by: Daniel Kessler <[email protected]> Signed-off-by: Morten Johansen <[email protected]>
Use the output of `chronyc -c tracking` to provide some basic NTP client status metrics. Signed-off-by: SuperQ <[email protected]> Signed-off-by: Morten Johansen <[email protected]>
Signed-off-by: Brian Candler <[email protected]> Signed-off-by: Morten Johansen <[email protected]>
Signed-off-by: Morten Johansen <[email protected]>
Signed-off-by: Morten Johansen <[email protected]> Signed-off-by: Morten Johansen <[email protected]>
Signed-off-by: Morten Johansen <[email protected]>
|
@SteveCooling Please rebase on master and resolve any merge conflicts. This PR should only touch storcli.py. Currently it touches four other files. |
|
Superseded-by: #202 Closing this PR, since it touches unrelated files and contains unresolved merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patches that allows the collector to report
battery_backup_healthywhen the BBU is absent (because there is a Cachevault supercap instead), as well as expose metrics for the Cachevault health directly.Tested on two different servers, one which has an actual Cachevault failure