nvme_metrics: support nvme-cli v2.11+ verbose JSON output #227
Conversation
nvme-cli v2.11 introduced a breaking change by forcing JSON output to always be verbose, resulting in a significantly different output structure. Fixes: #226 Signed-off-by: Daniel Swarbrick <[email protected]>
Since the shell script collector does not support nvme-cli v2.11+, and was already effectively superseded by nvme_metrics.py, this is no longer needed. Signed-off-by: Daniel Swarbrick <[email protected]>
|
This PR aims solely to add support for nvme-cli v2.11+, which produces more verbose and deeply nested JSON output than previous versions of the tool. Some decisions that were made in the past regarding the nvme_metrics collector (i.e., the original shell script version) do not translate so well to this deeply nested information, and take a rather naïve approach to NVMe namespaces (effectively equating them to individual devices). This will ideally require some breaking changes to the metrics produced in terms of metric names and labels. At the same time, there is a growing likelihood that this collector may be run in environments which have non-local NVMe devices, e.g. NVMe over fabrics or NVMe over TCP, which should perhaps be distinguished with a |
nvme-cli v2.11 introduced a breaking change by forcing JSON output to always be verbose, resulting in a significantly different output structure.
Also drop the obsolete nvme_metrics.sh shell script collector, which will not work with nvme-cli v2.11+ (unless it were also refactored).
Fixes: #226