Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert auth_type guage #173

Merged

Conversation

Jaskaranbir
Copy link
Contributor

@Jaskaranbir Jaskaranbir commented Oct 14, 2024

The auth_type has non-float values like md5 which breaks the exporter here:

value, err := strconv.ParseFloat(string(values), 64)

Also fixes #172

Signed-off-by: Jaskaranbir <[email protected]>
@Jaskaranbir Jaskaranbir force-pushed the revert-authtype-collector branch from ad84863 to 9fbf20a Compare October 14, 2024 01:52
@stanhu
Copy link
Contributor

stanhu commented Oct 14, 2024

FYI @SuperQ

@stanhu stanhu merged commit a5b3a8c into prometheus-community:master Oct 14, 2024
4 checks passed
SuperQ added a commit that referenced this pull request Oct 14, 2024
* [BUGFIX] Revert auth_type guage #173

Signed-off-by: SuperQ <[email protected]>
@SuperQ SuperQ mentioned this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v0.10.0 breaks SHOW CONFIG
2 participants