Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add collector test #178

Merged
merged 3 commits into from
Oct 18, 2024
Merged

Add collector test #178

merged 3 commits into from
Oct 18, 2024

Conversation

Sticksman
Copy link
Contributor

Write expected test values for showlists and query config

@Sticksman
Add collector test
b932e8a 
Signed-off-by: Felix Yuan <[email protected]>
@Sticksman
Add license header
04acc42 
Signed-off-by: Felix Yuan <[email protected]>
@Sticksman
Fix import error
0d86c3e 
Signed-off-by: Felix Yuan <[email protected]>
@Sticksman
Copy link
Contributor Author

cc @SuperQ

@stanhu
Copy link
Contributor

stanhu commented Oct 18, 2024

Thanks! Would you mind adding a GitHub Actions that will run the tests?

@stanhu
Copy link
Contributor

stanhu commented Oct 18, 2024

Never mind, it seems we run tests on Circle CI here.

@stanhu stanhu merged commit 6ecb3e5 into prometheus-community:master Oct 18, 2024
4 checks passed
@stanhu
Copy link
Contributor

stanhu commented Oct 18, 2024

Thanks, this is great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sticksman @stanhu