Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add usename to pg_process_idle metric #954

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rezaxd
Copy link

@rezaxd rezaxd commented Nov 11, 2023

Add usename to query of pg_process_idle metric.

@rezaxd rezaxd force-pushed the master branch 2 times, most recently from c656d09 to 883e7b0 Compare November 11, 2023 10:10
Copy link
Contributor

@sysadmind sysadmind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The database scanning wasn't updated so this will fail and there is no label changes. Is the intention to add a label to the metric?

@@ -52,11 +52,12 @@ func (PGProcessIdleCollector) Update(ctx context.Context, instance *instance, ch
SELECT
state,
application_name,
usename,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation is not correct here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for that. But I fixed that in force-push. Am I right?
Thank for your time.

@rezaxd
Copy link
Author

rezaxd commented Nov 15, 2023

usename added to labels now.

@rezaxd rezaxd requested a review from sysadmind November 15, 2023 11:13
@rezaxd rezaxd force-pushed the master branch 5 times, most recently from d3dc319 to 68bc21b Compare November 19, 2023 13:55
@rezaxd
Copy link
Author

rezaxd commented Nov 19, 2023

Hello dear @sysadmind !
Fixed my mistakes. Sorry for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants