chore: dont rely on slice labels #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaHoffmann
force-pushed
the
mhoffm-dont-rely-on-slice-labels
branch
2 times, most recently
from
d63b908 to
af48549
Compare
SuperQ
approved these changes
Jan 26, 2024
|
@MichaHoffmann can you give me a bit more context? How is this code affecting external behavior in the Thanos build? |
|
@squat There is the new "stringlabels" code in Prometheus itself. When switching to this implementation, accessing the slice directly is no longer allowed. |
|
Here's what you get if you build prom-label-proxy now: With this change, the build is successful. |
What @SuperQ said! Just adding context that I want to convert Thanos to be compatible with the stringlabels tag and there are more build failures, this was just one of them and it seemed easy enough to fix. |
bboreham
reviewed
Jan 27, 2024
Signed-off-by: Michael Hoffmann <[email protected]>
MichaHoffmann
force-pushed
the
mhoffm-dont-rely-on-slice-labels
branch
from
af48549 to
2bd8cbc
Compare
squat
approved these changes
Jan 27, 2024
|
And soon |
SuperQ
added a commit
that referenced
this pull request
Jan 27, 2024
Internal change for library compatibility. No user-visible changes. * [CHANGE] Don't rely on slice labels #184 Signed-off-by: SuperQ <[email protected]>
Merged
squat
pushed a commit
that referenced
this pull request
Jan 27, 2024
Internal change for library compatibility. No user-visible changes. * [CHANGE] Don't rely on slice labels #184 Signed-off-by: SuperQ <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to proceed a bit on trying to convert thanos to build with stringlabels and prom-label-proxy is used as a library there. This would fix this build error for me!