Add device type support

Allow passing a custom `-d` / `--device=` flag to smartctl. The default is the same (`auto`) as upstream smartctl. Fixes: #26 Signed-off-by: SuperQ <[email protected]>
prometheus-community · Jan 10, 2023 · b173b88 · b173b88
1 parent d5aa228
commit b173b88
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/main.go b/main.go
@@ -66,6 +66,9 @@ var (
 	smartctlInterval = kingpin.Flag("smartctl.interval",
 		"The interval between smarctl polls",
 	).Default("60s").Duration()
+	smartctlDeviceType = kingpin.Flag("smartctl.device-type",
+		"The device type (-d / --device)",
+	).Default("auto").String()
 	smartctlDevices = kingpin.Flag("smartctl.device",
 		"The device to monitor (repeatable)",
 	).Strings()

diff --git a/readjson.go b/readjson.go
@@ -62,9 +62,10 @@ func readFakeSMARTctl(logger log.Logger, device string) gjson.Result {
 }
 
 // Get json from smartctl and parse it
-func readSMARTctl(logger log.Logger, device string) (gjson.Result, bool) {
-	level.Debug(logger).Log("msg", "Collecting S.M.A.R.T. counters", "device", device)
-	out, err := exec.Command(*smartctlPath, "--json", "--info", "--health", "--attributes", "--tolerance=verypermissive", "--nocheck=standby", "--format=brief", device).Output()
+func readSMARTctl(logger log.Logger, deviceType string, device string) (gjson.Result, bool) {
+	level.Debug(logger).Log("msg", "Collecting S.M.A.R.T. counters", "device_type", deviceType, "device", device)
+	deviceTypeFlag := fmt.Sprintf("--device=%s", deviceType)
+	out, err := exec.Command(*smartctlPath, "--json", "--info", "--health", "--attributes", "--tolerance=verypermissive", "--nocheck=standby", "--format=brief", deviceTypeFlag, device).Output()
 	if err != nil {
 		level.Warn(logger).Log("msg", "S.M.A.R.T. output reading", "err", err)
 	}
@@ -96,7 +97,7 @@ func readData(logger log.Logger, device string) gjson.Result {
 
 	cacheValue, cacheOk := jsonCache.Load(device)
 	if !cacheOk || time.Now().After(cacheValue.(JSONCache).LastCollect.Add(*smartctlInterval)) {
-		json, ok := readSMARTctl(logger, device)
+		json, ok := readSMARTctl(logger, *smartctlDeviceType, device)
 		if ok {
 			jsonCache.Store(device, JSONCache{JSON: json, LastCollect: time.Now()})
 			j, found := jsonCache.Load(device)