feat: add JSON testing data #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add README about test data. - Add script to redact sensitive fields. - Add JSON testing data collected from many systems, with redaction of sensitive fields. The initial corpus includes: - NVME drives - SAS drives - HDD only, no SSD - SCSI drives - HDD only, no SSD - SATA drives - SSD & HDD Signed-off-by: Robin H. Johnson <[email protected]>
|
@NiceGuyIT here's the test data PR as requested; with some redaction tooling. |
|
This will be merged and used for CI? 🤔 |
|
@k0ste yes, I would plan to use this for CI; do you have drives that differ significantly from these models I collected? |
I don’t know what to mean by significant, but yes, - I will prepare data on models that do not currently exist |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial corpus includes: