Allow web.listen-address to be unix domain sockets
#286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Context / Background Prometheus push gateway is used extensively in the systems I work on. The current setup I use is to have the pushgateway container running adjacent to my application and to push metrics over the TCP loopback interface. As the usage of the pushgateway has scaled up, the overhead and reliability have become worse. Using unix domain sockets would allow metrics to be collected in a much quicker and reliable way. ## In this PR - Added an ability to set `--web.listen-address` to `unix:/path/to/sock` as a way of specifying that the server should open a listener using "unix" domain sockets. ## How this was tested - I have made patches against prometheus push gateway and made a proof-of-concept that seems to work correctly. Signed-off-by: nick comer <[email protected]>
nkcmr
force-pushed
the
nick/unix-listen
branch
from
6bea421 to
ba74184
Compare
|
@SuperQ Hello! 👋 — I've seen you be the one to merge stuff around here. Mind if I get a review/feedback whenever you get a chance? |
|
That seems like an XY Problem. If pushing to the pushgateway is a performance bottleneck, perhaps you should not be using the pushgateway in the first place. The pushgateway is not meant as a high performance metrics sink. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context / Background
Prometheus push gateway is used extensively in the systems I work on. The current setup I use is to have the pushgateway container running adjacent to my application and to push metrics over the TCP loopback interface. As the usage of the pushgateway has scaled up, the overhead and reliability have become worse.
Using unix domain sockets would allow metrics to be collected in a much quicker and reliable way.
In this PR
--web.listen-addresstounix:/path/to/sockas a way of specifying that the server should open a listener using "unix" domain sockets.How this was tested